hypha-dao / hashed-wallet

Hashed Wallet
MIT License
3 stars 3 forks source link

generating deep link data and packing it into a URI #127

Closed n13 closed 2 years ago

n13 commented 2 years ago

πŸ—ƒ Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

Generate deep link data

I changed some of the guardian data model classes

Also changed a use case

Did not change code upstream since I think we don't need a lot of it - we don't need to keep track of the recovery process, it's all on chain. I think the only thing we need to keep track of on the user's end is which account addresses they have initiated recoveries for.

Once the recovery is complete we will be able to access the "proxy" table on the recovery pallet to see which active recoveries an account has (next PR)

βœ… Checklist

πŸ•΅οΈβ€β™‚οΈ Notes for Code Reviewer

This creates a link

https://app.hashed.io/vouch/?lostAccount=&rescuer=

Which is then wrapped into a deeplink.

It does not parse the incoming link.

I think some of the old code should be removed - really all we need is take two strings, lostAccount and rescuer, and create a deep link with that for the user to share with their guardians.

No need to have a lot of lookups and logic as we needed on the seeds light wallet.

πŸ™ˆ Screenshots

πŸ‘―β€β™€οΈ Paired with

gguijarro-c-chwy commented 2 years ago

https://app.hashed.io/vouch/?lostAccount=&rescuer=

Is this link missing something?

n13 commented 2 years ago

https://app.hashed.io/vouch/?lostAccount=&rescuer=

Is this link missing something?

The data...

5FyG1HpMSce9As8Uju4rEQnL24LZ8QNFDaKiu5nQtX6CY6BH 5GwwAKFomhgd4AHXZLUBVK3B792DvgQUnoHTtQNkwmt5h17k

https://app.hashed.io/vouch/?lostAccount=5FyG1HpMSce9As8Uju4rEQnL24LZ8QNFDaKiu5nQtX6CY6BH&rescuer=5GwwAKFomhgd4AHXZLUBVK3B792DvgQUnoHTtQNkwmt5h17k

^^ like this