hypha-dao / hashed-wallet

Hashed Wallet
MIT License
3 stars 3 forks source link

set deployment target and pods to iOS 14 #140

Closed n13 closed 2 years ago

n13 commented 2 years ago

πŸ—ƒ Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

Build broke in new XCode 14

Reason is that flutter_inapp_webview has issues in iOS < 14:

https://github.com/pichillilorenzo/flutter_inappwebview/issues/1216

But since we require iOS 14 anyway since it's the oldest iOS version that can run Polkadot JS, I just bumped the deployment version to iOS 14.

We could probably, with a lot of effort, make it work in iOS 13 and below

That would require us getting a polkadot JS build that doesn't require WASM - I think it's possible, since those pieces in Polkadot JS that need WASM to run in theory have fallback implementations in pure JS. I wasn't able to get this to work when I tried it briefly though, and testing was very slow and painful, having to create a new JS package with webpack, then running the app to see if it fails.

And there's other workarounds for flutter_inapp_webview

βœ… Checklist

πŸ•΅οΈβ€β™‚οΈ Notes for Code Reviewer

πŸ™ˆ Screenshots

πŸ‘―β€β™€οΈ Paired with