Feature/restart connection reloaded - Githubissues

hypha-dao / hashed-wallet

Hashed Wallet

MIT License

3 stars 3 forks source link

Feature/restart connection reloaded #145

Closed n13 closed 2 years ago

n13 commented 2 years ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

Cleaning up and improving reconnect code

✅ Checklist

[ ] Github issue details are up to date for people to QA.
[ ] I have tested all my changes.

🕵️‍♂️ Notes for Code Reviewer

This is our refactoring of reconnection - the old code didn't work very well.

Still needs some improvement, specifically to answer these questions:

Who detects disconnection?
Who issues reconnect() and how do we prevent endless reconnect loops?
What happens to network calls while the network is down?
How do we show connect status in the UI

🙈 Screenshots

👯‍♀️ Paired with

@github-handle or "nobody" if you did not pair.

n13 commented 2 years ago

Merging this now, as it's been in a branch for a while