n13
commented
1 year ago Oh - that's very cool - making that change and checking in
On Sep 30, 2022, at 3:29 AM, Gerardo Guijarro @.***> wrote:
@gguijarro-c-chwy commented on this pull request.
In lib/screens/authentication/recover/recover_account_overview/interactor/components/recover_account_overview_view.dart https://github.com/hypha-dao/hashed-wallet/pull/146#discussion_r983945372:
- print("rec acct ${state.recoveredAccounts}");
- }
- return Padding(
- padding: const EdgeInsets.all(16),
- child: Column(
- children: [
- SettingsCard(
- icon: const Icon(Icons.replay_circle_filled_outlined),
- title: "Recover an Account",
- description: "Recover an account with the help of the guardians set for that account.",
- onTap: () async {
- BlocProvider.of
(context).add(const OnRecoverAccountTapped()); - },
- ),
- const SizedBox(height: 16),
- if (state.activeRecovery != null) Yes, i pasted the fix in this comment for you lol.
You only need one if statement and (...)
if(Bool)...[
— Reply to this email directly, view it on GitHub https://github.com/hypha-dao/hashed-wallet/pull/146#discussion_r983945372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAP7BFZVMX2SIQKXP2FX6LWAXU25ANCNFSM6AAAAAAQXZXKSU. You are receiving this because you modified the open/close state.
🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
As per design spec
✅ Checklist
🕵️♂️ Notes for Code Reviewer
1 - Testing with mock data for this PR
2 - Added a setting for the currently active recovery "lost account" - this data cannot be retrieved from chain.
It can be retrieved when entering the same account to recover again though, meaning there's only ever one active recovery on chain with a specific rescuer / lost account pair.
So if I am the same rescuer, and enter the same lost account as on another device, I am getting the same active recovery back We need to still store this value, next PR
🙈 Screenshots
👯♀️ Paired with