propagate JavaScript errors back to flutter - Githubissues

hypha-dao / hashed-wallet

Hashed Wallet

MIT License

3 stars 3 forks source link

propagate JavaScript errors back to flutter #154

Closed n13 closed 1 year ago

n13 commented 1 year ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

fixes the bug where the handler would wait forever when there was a JS error, since complete was never called.

✅ Checklist

[ ] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵️‍♂️ Notes for Code Reviewer

We communicate with JS through console messages.

We were not handling error messages at all - I think this was in the original codebase too.

So JS errors would result in forever hanging handlers...

🙈 Screenshots

👯‍♀️ Paired with