🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Moving forward some missing pieces - removed mocks and found bugs ;)
✅ Checklist
[ ] Github issue details are up to date for people to QA.
[x] I have tested all my changes.
🕵️♂️ Notes for Code Reviewer
This removes mock results and uses real results
Some changes necessary
Also enforcing naming conventions for recovery
lostAccount is the account being recovered (even if we are recovering it, we keep calling it lostAccount)
rescuer is the account trying the rescue - in our current wallet that's always the same as accountService.currentAccount.addresss - but we want to keep the UX somewhat flexible.
rescuer could be any account we have in our keychain - as long as we have signing rights, meaning the private key, we can sign.
🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
Moving forward some missing pieces - removed mocks and found bugs ;)
✅ Checklist
🕵️♂️ Notes for Code Reviewer
This removes mock results and uses real results
Some changes necessary
Also enforcing naming conventions for recovery
lostAccount is the account being recovered (even if we are recovering it, we keep calling it lostAccount)
rescuer is the account trying the rescue - in our current wallet that's always the same as accountService.currentAccount.addresss - but we want to keep the UX somewhat flexible.
rescuer could be any account we have in our keychain - as long as we have signing rights, meaning the private key, we can sign.
🙈 Screenshots
👯♀️ Paired with