search

hypha-dao / hashed-wallet

Hashed Wallet
MIT License
3 stars 3 forks source link

Add logo icons to network switcher #173

Closed n13 closed 1 year ago

n13 commented 1 year ago

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)

Adding the chains to the network switcher

Adding images and logos, loading logos from github polkadot JS

✅ Checklist

🕵️‍♂️ Notes for Code Reviewer

🙈 Screenshots

image

👯‍♀️ Paired with

n13 commented 1 year ago

Need to move forward with this, but will find solution for the avatar widget in another PR @gguijarro-c-chwy

n13 commented 1 year ago

Agree on the pattern

This component was copied from an existing component in the seeds light wallet so this is where that code came from

On Sun, Nov 27, 2022 at 11:15 PM Gerardo Guijarro @.***> wrote:

@.**** commented on this pull request.

In lib/components/chain_avatar.dart https://github.com/hypha-dao/hashed-wallet/pull/173#discussion_r1032957299 :

  • });
  • @override
  • Widget build(BuildContext context) {
  • return ClipRRect(
  • borderRadius: BorderRadius.circular(size / 2),
  • child: Container(
  • width: size,
  • height: size,
  • child: _buildContent(context),
  • ),
  • );
  • }
  • Widget _buildContent(BuildContext context) {
  • if (image != null) {

its fine here, this is a small scale project and this wont change. But when we write UI components, there is always a way to move most if not all logic away from them.

— Reply to this email directly, view it on GitHub https://github.com/hypha-dao/hashed-wallet/pull/173#discussion_r1032957299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAP7BBTT76BDERWYWFHUTDWKOCLRANCNFSM6AAAAAASF6XSWQ . You are receiving this because you modified the open/close state.Message ID: @.***>