search

hypha-dao / hypha-wallet

Hypha Wallet - Authenticator - All the things.
3 stars 2 forks source link

fix: set AppBar scrolledUnderElevation to 0 #295

Closed Zied-Dahmani closed 2 months ago

Zied-Dahmani commented 2 months ago

Scope

Ticket

I fixed the issue by setting scrolledUnderElevation to 0, which prevents the AppBar color from changing when scrolling on the transaction details page.

Screenshots

Before After
before after
Zied-Dahmani commented 2 months ago

Approved.

I am not 100% sure if app bar isn't supposed to change color but no strong opinion on it.

The color change behavior of the AppBar in Flutter's Material 3 (M3) design system is not necessarily a bug but rather a design choice aligned with Material Design guidelines. However, this behavior can become an "issue" if it conflicts with the developer's or designer's vision for the app. This is especially noticeable in light mode, where the color change may not always lead to a visually appealing appearance.

n13 commented 2 months ago

Alright I didn't check light mode - On Aug 31, 2024, at 08:18, Zied Dahmani @.***> wrote:

Approved. I am not 100% sure if app bar isn't supposed to change color but no strong opinion on it.

The color change behavior of the AppBar in Flutter's Material 3 (M3) design system is not necessarily a bug but rather a design choice aligned with Material Design guidelines. However, this behavior can become an "issue" if it conflicts with the developer's or designer's vision for the app. This is especially noticeable in light mode, where the color change may not always lead to a visually appealing appearance.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>