search

hypha-dao / hypha-wallet

Hypha Wallet - Authenticator - All the things.
3 stars 2 forks source link

refactor: sort active proposals by DAO and expiration #301

Closed Zied-Dahmani closed 1 week ago

Zied-Dahmani commented 2 weeks ago

Scope

Ticket

I have implemented the logic to sort active proposals by DAO name and expiration date.

Zied-Dahmani commented 1 week ago

refactor so isExpired code is only in 1 place (see comments)

You are absolutely right about the comments. However, I’m marking this as a 'to-do' item (which is why I haven’t implemented it as an extension yet). I believe that active proposals should not include expired ones.