hyphacoop / hyphacoop-chatbot

A friendly helper robot that lives in Hypha's chat rooms
https://hyphacoop-chatbot.herokuapp.com
0 stars 0 forks source link

Test coverage for existing features #18

Closed patcon closed 4 years ago

patcon commented 4 years ago

This initial comment is collaborative and open to modification by all.

Task Summary

🎟️ Re-ticketed from: #
🗣 Loomio: N/A
📅 Due date: N/A
🎯 Success criteria: Folks who don't know the code and review comfortably.

Decided to spin this out of other issues, since figuring out testing for hubot might be slower.

To Do

patcon commented 4 years ago

Ok, added tests for travisCI and GitHub Actions, as was curious to see how they compare.

I'd like to merge both, to develop a better understanding going forward which is the better tool.

patcon commented 4 years ago

Tests should now cover all the use-cases of the bot! if the test output or naming of test cases could be improved, happy to do so!

(There was an indentation fix, but it was just from resolving a merge conflict correctly.)

patcon commented 4 years ago

Since this is just some tests, and it can only improve the situation, going to merge