search

hyphacoop / social.distributed.press

A Social Inbox for Decentralized Publishing and ActivityPub.
https://hypha.coop/dripline/announcing-dp-social-inbox/
GNU Affero General Public License v3.0
23 stars 3 forks source link

Tildes in activity IDs are not parsed correctly #67

Closed fauno closed 2 months ago

fauno commented 3 months ago

While working on https://github.com/hyphacoop/distributed-press-organizing/issues/158 I noticed some replies collection return 404 and others not. It seems the router has an issue with tilde characters.

This doesn't work:

https://social.distributed.press/v1/@sutty@sutty.nl/inbox/replies/https%3A%2F%2Fsutty.nl%2Flanzamiento-nueva-funci%25C3%25B3n-de-moderaci%25C3%25B3n-para-los-sitios-conectados-al-fediverso.jsonld

This works:

https://social.distributed.press/v1/@sutty@sutty.nl/inbox/replies/https%3A%2F%2Fsutty.nl%2Fsutty-visita-hackbo.jsonld

RangerMauve commented 3 months ago

That's so unexpected. :/ Maybe we should use a different encoding?

fauno commented 3 months ago

i'm not sure if it's an issue with fastify or leveldb?

RangerMauve commented 3 months ago

99% sure it's in fastify. Probs something to do with unicode

sutty-coop commented 2 months ago

Fauno and Mauve can hack on this next week