search

hyphacoop / social.distributed.press

A Social Inbox for Decentralized Publishing and ActivityPub.
https://hypha.coop/dripline/announcing-dp-social-inbox/
GNU Affero General Public License v3.0
23 stars 3 forks source link

fix: parse object.id in performUndo() and add tests #70

Closed magush27 closed 1 month ago

magush27 commented 3 months ago

Fixed issue https://github.com/hyphacoop/distributed-press-organizing/issues/150

sutty-coop commented 2 months ago

@RangerMauve I asked Agus about this and they said this is done and awaiting for your ok. Let us know how you see it. If it's done, I have to close this PR as well as issue 150 https://github.com/hyphacoop/distributed-press-organizing/issues/150

akhileshthite commented 2 months ago

@RangerMauve I asked Agus about this and they said this is done and awaiting for your ok.

Let us know how you see it. If it's done, I have to close this PR as well as issue 150 https://github.com/hyphacoop/distributed-press-organizing/issues/150

Hey, don't close this PR, it's not merged yet. I've requested some changes.

Ping @magush27

RangerMauve commented 2 months ago

@magush27 the tests aren't passing, mind fixing them? Seems you're missing a function

magush27 commented 2 months ago

@magush27 the tests aren't passing, mind fixing them? Seems you're missing a function

yes, I'm on this right now

magush27 commented 2 months ago

@RangerMauve the tests works well on push and in my local computer but not on pull_request, what is the problem?

akhileshthite commented 2 months ago

@RangerMauve the tests works well on push and in my local computer but not on pull_request, what is the problem?

Hey, update your node version to 19.9.0 to resolve those gh action errors :)

RangerMauve commented 2 months ago

Ah, yeah merge the latest main branch into this.

git pull origin/main should do the trick

fauno commented 1 month ago

@RangerMauve @akhileshthite i merged main!