search

hyphanet / java_installer

The java-based installer
https://freenetproject.org/
25 stars 19 forks source link

Remove JAVA_HOME override for OS X which defaults to using 1.5.0 JVM #1

Closed RichyRich closed 12 years ago

RichyRich commented 13 years ago

As mentioned on the mailing list, removing this code allows OS X to use the latest version of Java installed (or whatever CurrentJDK is pointing at) rather than forcing it to use 1.5.0_x (which is most likely out of date now).

I think this probably made sense a while ago as, IIRC, OS X shipped with 1.4 as the default even though 1.5 may have been available and not many users would know or care how to repoint the CurrentJDK symlink. I don't think this case is relevant any more as installing java updates now appear to update the CurrentJDK link correctly, also using this should allow for more options (e.g. the user can point currentjdk at another jvm installation if they so wish).

freenet commented 12 years ago

Thanks!

freenet commented 12 years ago

Mac-related help is always welcome!