search

hyphanet / java_installer

The java-based installer
https://freenetproject.org/
25 stars 19 forks source link

(macOS) Fix 64 bit executable not being selected on 64 bit platform. #19

Closed Qxe5 closed 3 years ago

Qxe5 commented 3 years ago

On macOS 64 bit:

Currently run.sh will only attempt to execute the 32 bit executable - wrapper-macosx-universal-32, and seems unaware of the 64 bit executable - wrapper-macosx-universal-64

This results in the error Bad CPU type in executable.

Qxe5 commented 3 years ago

Note: My editor stripped some whitespace from the file. The only significant change is the removal of lines 283 and 284, with the insertion of line 283.

Thynix commented 3 years ago

I merged #18, so the only changes this would make are the whitespace stripping, which if we want to do shouldn't be committed with a message about the 64-bit thing.

Qxe5 commented 3 years ago

Thanks for getting a fix merged.

I put the low priority whitespace changes in a separate pull request in case they were desired: https://github.com/freenet/java_installer/pull/20

Thynix commented 3 years ago

Sure! Hygiene is good, thanks. IMO more repos ought to have linters in pre-commit hooks to help prevent formatting problems. Hm, now there’s a project!

On Fri, May 28, 2021 at 3:06 AM, Qxe5 @.***> wrote:

Thanks for getting a fix merged.

I put the low priority whitespace changes in a separate pull request in case they were desired: #20

Might be a good idea to clean it out every once in a while :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.