search

hyphanet / plugin-KeyUtils

Freenet utility plugin for inspecting keys, sites, and splitfiles
https://freenetproject.org/
7 stars 17 forks source link

Fix post purge db4o #7

Closed saces closed 9 years ago

saces commented 10 years ago

build fixes

Thynix commented 10 years ago

Thanks! The content of this looks good; I will merge this once purge-db4o is impending. Two things:

  1. Once this is otherwise ready to merge would you be willing to reopen with this change squashed into a single commit?
  2. The coding standards include indenting with 4 spaces. My goal is that with these standards in effect no lines using tabs for indentation are added in the diff between releases.VerySimpleGetter.getCallback() was already indented this way; I'm assuming it needs to continue to exist because it doesn't look too useful. If you'd rather not do this I can do it after this is merged.
saces commented 10 years ago
  1. Yes.
  2. Ok.
Thynix commented 9 years ago

purge-db4o is merged into fred/next. Could you reopen (or force push) this as a single commit? For the commit message guidelines see here.

Thynix commented 9 years ago

Merged as c8d6ee8aa89b531a6c1dde0b252b5b8adb1b9ae6. Thanks! There's still

 [javac] [snip]/plugin-KeyUtils/src/plugins/KeyUtils/VerySimpleGetter.java:19:
        error: VerySimpleGetter is not abstract and does not override abstract method getSchedulerGroup() in ClientRequester
[javac] public class VerySimpleGetter extends ClientRequester {
[javac]        ^

but I'm looking into having ClientRequester implement ClientRequestSchedulerGroup too.

Thynix commented 9 years ago

I tried to restore sanity in e4a6d5b70852dbfcc2a80077714a7a29b5c66e15. No additional changes are needed.