search

hyphanet / pyFreenet

Python FCPv2 library and utilities
https://freenetproject.org/
Other
60 stars 24 forks source link

Code review bab #2

Closed ArneBab closed 11 years ago

ArneBab commented 11 years ago

I reviewed everything in fcp/ except for sitemgr.py, xmlobject.py and xmlrpc.py [01:14] <Arne`> that means most of pyFreenet is reviewed now (most of the scripts are just 3-line wrappers around stuff in fcp/)

I did not add tests for everything, though.

So at the moment I‘m pretty sure that everything in fcp/ except for sitemgr.py, xmlobject.py and xmlrpc.py is not evil. For those I assume good will, but naturally that is not enough to warrant full trust.

ArneBab commented 11 years ago

Everything except for freedisk, minibot, refbot and updater.py is reviewed.

freedisk is complex.

minibot, refbot and updater might not be needed anymore.

ArneBab commented 11 years ago

I just reviewed the freedisk runner script, too.

I only reviewed the code in fcp/freenetfs.py roughly, though. I’m pretty sure that it is not evil.

I now moved refbot, minibot and updater into the folder historic/ and added a note that those aren’t reviewed. With that all of pyFreenet except for historic/* is reviewed.