hyphanet / pyFreenet

Python FCPv2 library and utilities
https://freenetproject.org/
Other
60 stars 24 forks source link

WithReadDirectory and WantReadDirectory are used interchangably causing an exception which prevents -d --disc to work correctly. #24

Closed PeterVerzijl closed 6 years ago

PeterVerzijl commented 6 years ago

https://github.com/freenet/pyFreenet/blob/a20a8cc0b92740503b8a16d90049f8b1ba4acd2a/fcp/put.py#L238

In node.py, put.py, sitemgr.py and upload.py the following key names are not consistent:

Global constants should be used instead of plaintext strings for identifying key-value pairs. This would have prevented such a thing.

PeterVerzijl commented 6 years ago

I'm going to close this issue as it has been replaced by the pull request.