search

hyphanet / wininstaller-innosetup

Windows installer for Freenet
18 stars 23 forks source link

Reference bundled zip for extraction #17

Closed desyncr closed 2 years ago

desyncr commented 2 years ago

Fixed the issue with the bundled zip and also remove unnecessary compression reducing compilation from 30s to 2s.

Using docker image: amake/innosetup from https://github.com/amake/innosetup-docker. Executable size: 173 MB.

$ docker run --rm -i -v "$PWD:/work" amake/innosetup FreenetInstall_InnoSetup.iss
...
Successful compile (2.941 sec). Resulting Setup program filename is:
Z:\work\Output\FreenetInstaller.exe
Thynix commented 2 years ago

Ah, this was trying to unzip the installer, not the installer zip. Nice find!

Is it necessary to switch to Format too? It seems preferable not to avoid build ing strings like the previous code does, if possible. Explicit arguments versus the shell parsing strings as a source of pain, I mean.

Edit: Thought the "not" might be unclear - clarified in strike through and italics.

desyncr commented 2 years ago

Is it necessary to switch to Format too? It seems preferable not to build strings like the previous code, if possible. Explicit arguments versus the shell parsing strings as a source of pain, I mean.

Yeah I think it's possible, I'll give it a try later today.

ArneBab commented 2 years ago

Awesome! Thank you very much!