hypherionmc / MoreCreativeTabs

Customize creative tabs the way you want it!
MIT License
4 stars 1 forks source link

[BUG] Duplicate items in replaced tabs #14

Open ElRichiRicon opened 7 months ago

ElRichiRicon commented 7 months ago

Describe the bug I replaced a vanilla tab and added some modded items. The added items appear twice.

To Reproduce Steps to reproduce the behavior:

  1. Follow the guide to replace a tab
  2. Add items to the new tab
  3. Open the tab in game
  4. See error

Expected behavior The added items should appear only once.

Screenshots image image

Versions:

Additional context This is a clean install with only this mod and the mod to give the items. The resourcepack also removes the original modded tab.

Crash Report If the game crashed, please include your latest crash report here

hypherionmc commented 7 months ago

I will admit, this mod has been an absolute mess on 1.19.2+. Mojang did a lot of changes to the inventory screens, and it basically broke the entire mod, and I had to rewrite a lot of the code again.

There was limited time for testing, and the releases that did go out are buggy, and should've been alpha's instead of releases.

Atm I don't find much time for modding, which is why one of the mod rewrites have been in progress for almost a full year. I'll try to fix this mod over the December holidays when I have some time off work.

The issue here might be caused by the "existing" items. I suspect it's not filtering the custom items from the existing items list, like it should

Jonaykon commented 5 months ago

i also get the same issue on some tabs (1.18.2)

Zaroz commented 1 month ago

same issue (1.20.1)