search

hypherionmc / MoreCreativeTabs

Customize creative tabs the way you want it!
MIT License
4 stars 1 forks source link

[BUG] Game crashes with MoreCreativeTabs and Supplementaries #17

Open Pipsqueak737 opened 7 months ago

Pipsqueak737 commented 7 months ago

Describe the bug This crash occurs when using both MoreCreativeTabs and Supplementaries. The game crashes while Forge is in its loading stage, but adding a creative tab resource pack after the game has fully loaded doesn't cause any issues. This crash only seems to occur when creative tabs are actually customized using MoreCreativeTabs. Without a resource pack, the game does NOT crash with both mods present.

To Reproduce Steps to reproduce the behavior:

  1. Download MoreCreativeTabs and the latest versions of Supplementaries and Moonlight Lib
  2. Apply a resource pack to change creative tabs using MoreCreativeTabs
  3. Close the game and relaunch it, it will crash during setup

Expected behavior The game should load as expected

Screenshots If applicable, add screenshots to help explain your problem.

Versions (DO NOT USE "LATEST"! I STEAL YOUR KNEE CAPS!):

Additional context Add any other context about the problem here.

Crash Report If the game crashed, please include your latest crash report here crash-2024-02-12_13.40.27-client.txt

hypherionmc commented 7 months ago

This is an interesting one, it's not MoreCreative Tabs, or supplementaries or even moonlib that's crashing, but forge itself.

Will have to check this one out, cause it's definitely interesting

Akoto090 commented 3 months ago

Did this got fixed on 1.2.1? https://modrinth.com/mod/morecreativetabs/version/1.20-1.2.1

RSNightKing commented 1 month ago

Any Updates?

hypherionmc commented 1 month ago

Finally had the courage to work on this mod again. Turns out the crash was caused by this mod, for one simple reason.... Our tabs are "fake" tabs, and supplementaries expect them to be real tabs, so I added a work around to give them the data they need, and it no longer crashes.

https://nightbloom.cc/project/morecreativetabs/files/WsanIX2a

This build also features a bunch of other bug fixes, before adding new features, so feedback would be great (I am going to sleep now, so will reply to any feedback later)