Several bugfixes (Search, OP Blocks tab)

MrKinau commented 1 year ago

This PR fixes:

Search: Search appeared to be broke due to the search tree, which did not update correctly. The search tree also did not update immediately after startup without doing /mct reloadTabs, thats why the update function is called again after building the search tab. I've not tested all features, only added a new tab, which worked for me.
OP Blocks Tab missing: The OP blocks tab was especially not shown regardless of the user setting. I don't know why this was done, but imo this tab is quite useful, thats why I re-added it.
During testing I realized the CreativeModeTabAccessor somehow interfers with the mixins and therefore blocking the mixin for getDisplayItems (I guess only during testing, because it's not obfuscated there), so I renamed this method in order to fix the mixin during testing

Everything done for the fabric version. Don't know if those bugs exist on the forge version as well or if they are fixed now. I've made the same changes in the forge version as well, but was not able to test them.

hypherionmc commented 1 year ago

Hi there. Thanks for the PR!

As far as I know these issues were only in the fabric version. The forge version was working fine.

The OP tab was originally disabled by default cause it always showed up empty for me, so I took it as the tab is un-used. Will do some testing on this over the weekend and push a release.

Thanks again :) Also, if you are in my discord, give me a ping so I can give you the contributors role

VOLKOUL commented 7 months ago

Will we be getting a bugfix update any time soon? This mod has amazing potential for large modpacks with a ton of tabs that need to be organized properly.

hypherionmc commented 7 months ago

Actually looking for people to help test the fix before releasing it.

https://ci.firstdark.dev/job/MoreCreativeTabs/job/1.20/

If it works, I can release it, until mojang breaks the hell out of it again

Poly2it commented 3 months ago

Actually looking for people to help test the fix before releasing it.

https://ci.firstdark.dev/job/MoreCreativeTabs/job/1.20/

If it works, I can release it, until mojang breaks the hell out of it again

It's been a while and the (quite severe) issue has still not had any fixes published. Is the patch still in a testing phase, or could it be uploaded to Modrinth? Thank you @hypherionmc.

hypherionmc commented 3 months ago

The patch was a failure, as confirmed by the contributor and other testers.

We honestly have no idea where to go from here, aside from just flat out removing some core features from the mod, or simply switching to a single mod loader to make it as compatible as possible.

One other possible workaround we spoke about is just forcing a tab reload when you join the game, since running the mct reloadTabs command seems to fix it, but I haven't had time to look at it yet.

Poly2it commented 3 months ago

That's too bad - welp. Reloading tabs doesn't fix search items disappearing upon querying in my experience. This mod is really valuable to my modpack, best of luck with your debugging.

hypherionmc / MoreCreativeTabs

Several bugfixes (Search, OP Blocks tab) #9