hypherionmc / sdlink

A simple to use Minecraft to Discord Chat linker with Whitelisting
MIT License
23 stars 7 forks source link

[Feature] Support Threads/Forum Posts (At least in webhook mode) #109

Closed laundmo closed 5 months ago

laundmo commented 8 months ago

As it stands, the bot cannot send messages to forum threads. I suspect partly because it parses webhook addresses instead of using them as-is.

A webhook can send to a thread or forum post using the ?thread_id=111111111 query parameter just fine. Using a thread webhook would be a nice workaround for being able to set the bot up for threads, but it seems not to send these webhooks successfully.

I understand that wanting to proxy a thread's chat is a rare use case, if it isn't worth it so be it.

hypherionmc commented 8 months ago

So supporting this would depend on the webhook library we make use of, discord-webhooks.

Last time I checked, they didn't support this yet. The webhook url is passed from the config directly to this library, and it handles the rest.

So if they support it, then yes we can too. If they don't, then they'd need to add support for it.

Just curious, what's the use case for this?

laundmo commented 8 months ago

I run a semi-official minecraft server for a discord community, the main admin of which didn't want to add a full channel for the server so theres a forun thread instead

hypherionmc commented 8 months ago

I see. That makes sense.

So basically you'd need us to support using a single thread or forum post to relay chats to and from?

laundmo commented 8 months ago

yup, but i fully understand if its too niche

hypherionmc commented 8 months ago

Found a way to make webhooks work. Will be released after testing.

With this release it will also be possible to use threads for chat and other relays

image

hypherionmc commented 5 months ago

Implemented in 3.1.0

mrbeezwax commented 5 months ago

Hey, thanks for adding this! Would it be worth updating the Documentation to also require the "Send Messages in Threads" bot permission? For me, I wasn't able to get it to send messages in the thread until I allowed this for the bot.

image

image