search

hypherionmc / simple-rpc-public

Simple-RPC Issues, wiki and data github
https://www.curseforge.com/minecraft/mc-mods/simple-discord-rpc/
14 stars 1 forks source link

[BUG] config files are ignored (not a bug, intentional behavior) #10

Closed Sanduhr32 closed 3 years ago

Sanduhr32 commented 3 years ago

TL;DR

A servers config can override the clients config if

{ "enabled" : true, "version" : Number, "multi_player" : { ... } }

in config/simple-rpc-server.json on the server as explained in the non-github wiki here, linked on curseforge.


Describe the bug Modify the simple-rpc-server.json for not pushing your servers ip to 100k+ via discord precense update events.

To Reproduce Steps to reproduce the behavior:

  1. Go to '$installLocation/config/simple-rpc-server.json'
  2. Remove '%ip%' from the description.
  3. Save the file
  4. Start MC & join a server

Expected behavior

  1. The config has been loaded & applied
  2. Your servers ip isn't displayed in your discord rpc.

Screenshots image

Versions (DO NOT USE LATEST! BE SPECIFIC!):

Additional context Privacy

hypherionmc commented 3 years ago

@Sanduhr32 Firstly, is the server side set to "enabled": true in the config file?

Secondly, just remove (%ip%) from both the client side and server config file

Sanduhr32 commented 3 years ago

I have to change a config of a client side mod on the server?

hypherionmc commented 3 years ago

If "enabled" is set to false in "simple-rpc-server.json", it reads the values of the config file on the client

Sanduhr32 commented 3 years ago

well which? there is one nested in 'multi_player' and one in the first scope.

hypherionmc commented 3 years ago

For more clarity:

The "simple-rpc-server.json" file is ALWAYS ignored on your client, except when playing a lan game.

So if you have simple RPC installed on your server and your want to override values, you need to change "enabled": false to "enabled": true and it will push the values from your server to the client.

Otherwise, just make the changes to "simple-rpc.json"

Sanduhr32 commented 3 years ago

I guess i should read the wiki before complaining. Tho this is very unconvenient set up that it doesn't warn you about a server overriding the local config for a client side mod.

hypherionmc commented 3 years ago

It doesn't override unless the simple-rpc-server.json file has enabled set to true....

Sanduhr32 commented 3 years ago

the modpack does exactly that. I wasn't aware that a server override was possible. I appreciate you for your help and am sorry for being a prick.

hypherionmc commented 3 years ago

No worries, I'll make the docs a bit clearer next time and remove it being a default value in a brand new config file

Sanduhr32 commented 3 years ago

I updated the issue with a TL;DR if anyone ever forgets to read. Btw the wiki of this repo should redirect to https://docs.hypherionmc.me/books/simple-rpc-user-manual/ instead or be sycnchronized with it.