search

hypherionmc / simple-rpc-public

Simple-RPC Issues, wiki and data github
https://www.curseforge.com/minecraft/mc-mods/simple-discord-rpc/
14 stars 1 forks source link

[BUG] Extensive Testing, Dimension Overrides Not Working #42

Closed Camawama closed 2 years ago

Camawama commented 2 years ago

Describe the bug I spent quite a bit loading my modpack, noticing it wasn't displayed correctly, closing the modpack, tweaking the config, re-opening the modpack, etc. I came to the conclusion that it is, in fact, a bug, and I am not losing my mind.

To Reproduce Steps to reproduce the behavior:

  1. Set a custom dimension override for a mod
  2. Open the world and teleport to the specific dimension
  3. Notice that it isn't being displayed correctly on Discord

Expected behavior In the CONFIG, it is set to say "%player% is Vibing on Mars" but it instead says "Currently in the Mars"

Screenshots InGame ConfigEditor

DiscordDisplay WhatisActuallyDisplayed

Versions (DO NOT USE LATEST! BE SPECIFIC!):

Additional context This mod has been the easiest and best to use by far. I really hope someone can explain what I'm doing wrong or fix the bug. Thank you!

hypherionmc commented 2 years ago

Hey there. Thanks for your report. Can you send me a copy of your config?

I think it may be our editor not properly saving stuff. I noticed this more and more, but people aren't reporting it

Camawama commented 2 years ago

GitHub doesn't support that file format. Here is a link to my CONFIG on Google Drive.

https://drive.google.com/file/d/1vz71Ev_HL37J9cObX-I0oWWdf_l-poTv/view?usp=sharing

hypherionmc commented 2 years ago

Thanks. Your config looks correct. Let me do some testing on my side as well. I'll keep you updated

Camawama commented 2 years ago

Thank you. I will be back in about 6 hours. Sleep is important lol.

Camawama commented 2 years ago

I am also now noticing that the IMAGE only shows up on MOBILE DISCORD image

hypherionmc commented 2 years ago

I am also now noticing that the IMAGE only shows up on MOBILE DISCORD image

You have image key overworld specified for the overworld override, but you don't have an image on your app matching that.

image

hypherionmc commented 2 years ago

Alright, so this is definitely a bug. I was returning the incorrect string to be checked against.

So to replicate, remove beyond_earth: from your overrides, and it will work.

Additionally, this build has a fix for the problem, so you can use it without changing anything. You can use it for testing so long, until I release the fix https://ci.firstdarkdev.xyz/job/Simple%20RPC%20Modern/job/1.18.2/10/artifact/artifacts/simple-rpc-1.18.2-3.1.10d.jar

Camawama commented 2 years ago

Ohh, the image things got reset when config reset itself on me, lol.

I am going to use the version currently out to the public so that when I publish the pack, it doesn't deny it on CurseForge. Hopefully, the new update will be out soon. Glad I was able to help find an issue!

hypherionmc commented 2 years ago

Sorry, I know it's been a while. Been busy with IRL things. I'm doing a release this week with the fix included.

Camawama commented 2 years ago

That's great news!

hypherionmc commented 2 years ago

Fixed with release 3.2.0