hypirion / clj-xchart

XChart wrapper for Clojure
https://hypirion.github.io/clj-xchart/
Eclipse Public License 1.0
112 stars 6 forks source link

marker-size? #12

Open rqcy opened 8 years ago

rqcy commented 8 years ago

Hi, if I understand correctly, the marker size can be set in the 2nd hash-map in xy-chart function (the 1st one described the data to be plotted). However, the 1st map also contains :style options such as :marker-color etc. I was wandering, if the marker size should not be defined in that 1st map (e.g. using :marker-size keyword). It would be more consistent and would allow to specify different marker sizes for various curves.

hypirion commented 8 years ago

Hi,

Yeah, this makes sense, but unfortunately it's a limitation in the XChart library itself. It's not impossible to fix this in clj-xchart, but I think I'd rather have this fixed upstream if they want to resolve it

rqcy commented 7 years ago

Could you explain the the what's the logic behind the maps? Do they correspond 1-to-1 to the xchart java library? So far I have problems to understand where to set certain parameters, e.g. :style has marker options, :series also has :marker, and axes style has :marker too. I can understand why it's useful to have general graph options and specific ones for each line, but three places seem confusing.

Thanks for explanation how to understand the maps in a more consistent way.

PS from the tutorial it's not clear what's the difference between style map and axis style (in render-options.md).

hypirion commented 7 years ago

I try to correspond 1-to-1 with XChart on the original properties, with exception of some options – I think the only one is annotation distance for pie charts when you set donut thickness. If it makes sense to have some utility properties, such as :font for setting all fonts, then I might decide to add it in if there is no XChart counterpart.

The properties in the style map (second param) is generally options on the graph itself. But in some cases, the style options are on some attribute on series. You can usually set all the style options on the series themselves, but for some unknown reason, the only way to set marker style in XChart is by setting it on the chart itself (there is no option on the series).