hypirion / clj-xchart

XChart wrapper for Clojure
https://hypirion.github.io/clj-xchart/
Eclipse Public License 1.0
112 stars 6 forks source link

Update to Xchart 3.5.0 #15

Open dm3 opened 7 years ago

dm3 commented 7 years ago

Includes support for

as well as a few other minor API additions.

Missing:

hypirion commented 7 years ago

Thanks! I'll have a look and try to get this merged during this weekend. So far it seems good, but there seems to be some upstream issues related to the new features (e.g. timmolter/XChart#226). Not sure what we should do about that yet.

dm3 commented 7 years ago

Given this is a bug in new functionality, it won't break any previous uses. We'll get the fix when it's fixed upstream. Would be great if you could release this set of changes.

hypirion commented 7 years ago

Yeah, that's reasonable. I have submitted the issue upstream anyway, so when it's fixed there, the fix should in theory propagate down for free.

I'll get around and look through the rest of it during today and tomorrow hopefully.

marco-m commented 5 years ago

Hello @hypirion did you have any chance to look at this PR ? Merci :-)

hypirion commented 5 years ago

@marco-m: Hi! Obviously this fell through some cracks. I am a bit busy today, but will put up a reminder to have a look at this tomorrow. (If I remember correctly, I only wanted to document the new features more properly before merging it in)