search

hypnauticals / homework-portfolio

0 stars 0 forks source link

Feedback on assignment 1 #1

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #1 Project: HTML/CSS Basics

Description

For the first assignment, you will begin creating the beginnings of your first website. Take what you've learned from class and build a portfolio site that showcases all of the projects you'll be completing over the next few weeks. Build two pages - an 'About Page' and a 'Portfolio' - that link to one another. Your 'About Page' should describe your mission and value proposition and your 'Portfolio' should include descriptions of the work you [will] do for Relaxr, Startup Matchmaker, and CitiPix.

Student: Carina Silva

Project URL: https://github.com/hypnauticals/homework-portfolio

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Link both pages together using a tag x
Use a unique title and a single unique h1 tag (so, each page should have one of each of these tags, and while on a particular page, the content of the title and the h1 can be the same, the content of these tags should be different on the "about" page then they are on the "portfolio" page x
Show images using img tags including unique alt attributes x
Use an external CSS stylesheet to style your pages x
Select at least 5 elements on the page and apply at least 5 different css properties (font-size, color, font-family, background, text-decoration) to these elements (so, your style.css will have at least 5 css rules, that each contain at least 5 CSS declarations) x
- Use at least 6 of these HTML tags on each page: (h1, h2, h3, h4, h5, h6, p, ul, ol, a, img, nav, span) x
Follow naming conventions, maintain consistency across your .html and .css files x
Indent nested elements to increase your code's readability x
TOTAL: 14/16
barryross commented 7 years ago

Carina,

Great work on this first assignment! You are doing some excellent things here...including making me laugh out loud at the Seinfeld reference...genius!

To clarify the marks I left off: I saw that only one page was using the external style.css file, and while you have unique title tags on your page which is great, I was hoping to see unique h1 tags as well, something like "About Art" and "Art's Portfolio"

I encourage you to take a look at the sample solution for assignment 1 to review the element selections there and how they are nested within each other: https://github.com/ga-students/FEWD_SM-31/tree/master/Unit_2/sample_solutions/assignment_1

Big picture, keep up the great work. Please see inline comments for additional info, and let me know if you have any questions!