search

hypothesis / browser-extension

The Hypothesis browser extensions.
BSD 2-Clause "Simplified" License
491 stars 128 forks source link

doesn't work on github1s #1020

Closed HardwayLinka closed 2 years ago

HardwayLinka commented 2 years ago

Can't do highlighting in github1s

image

robertknight commented 2 years ago

github1s presents code inside Visual Studio Code, which is a complex web application that is very different to a typical web page. As a general rule, Hypothesis does not support complex document viewers with custom rendering logic, except where we have implemented specific support for them (eg. PDF.js, VitalSource Bookshelf). For GitHub, you can however annotate in the regular source code view, although I note there is currently an issue that GitHub's own styles override Hypothesis's highlighting.