Open mattdricker opened 2 years ago
I can confirm that text selection on an iPad on PDFs in the browser with Hypothesis is terribly bad, nigh unusable, and that selecting and annotating text in other document types, e.g. HTML, is not delightful either. This is nothing new, but is becoming more problematic as more of our users want (reasonably) to use iPads to annotate content, and more of our content is PDF-based.
I’d like us to spend some time investigating these issues this coming cycle, with the understanding that there is no obvious low-effort solution, and there is a possibility of finding no short-term mitigation options. i.e. There is some risk that we won't be able to make this better, or at least not without significant endeavor.
What we can look at:
Our goal in the next couple of weeks is to understand the problem and what our options are, with a goal of choosing one of those options.
This isn't a great sign: https://github.com/mozilla/pdf.js/issues/15691
I started poking at the possibility of re-using the custom image text layer (ImageTextLayer
) that we created for VitalSource PDF books, in PDF.js as well. Compared to PDF.js's own text layer, our one has more structure to it, which can help guide the selection interface provided by the browser.
I created https://github.com/hypothesis/client/issues/5201 as a sub-task for exploring the aforementioned ImageTextLayer-based solution.
I moved this to the backlog as I am not actively working on it.
Bug report form
Reported by user: https://app.hubspot.com/contacts/6291320/ticket/1126006850
Steps to reproduce
Expected behaviour
Text selection visual UI should behave as expected without expanding to cover the entire document. Additionally, the Annotate icon should display as if there is selected text to annotate.
Browser/system information
Tested on iPad (8th generation), iPadOS 15.7. Tested with both the latest version of Canvas app, and opening assignment directly in Chrome browser.