Open Chealer opened 6 years ago
From a quick look, I think this is what is happening:
<link>
tag pointing to the edit page: <link rel="alternate" type="application/x-wiki" title="Edit this page!" href="tiki-editpage.php?page=HomePage2">
.<textarea>
<hypothesis-highlight>
node. AFAIK a <textarea>
tag cannot have children and so this process doesn't work properly, resulting in the matching text just being removed.The current highlighting mechanism cannot work inside a <texarea>
so I suggest there are a couple of things we should do here:
<link rel="alternate" ...>
tags in the page.Many thanks @robertknight
Your 2 first quick look points must be right - well spotted. I don't know Hypothesis enough to tell but I guess 3 and 4 are correct too.
As for your suggestions, I am not sure 1 is needed, but 2 must be.
I was demonstrating Hypothes.is to a colleague using the Tiki Wiki CMS Groupware web application engine. I annotated a word part of the default wiki page, then went on to modify the wiki page, to show that Hypothes.is deals with changes to the annotated text.
To my great surprise, in the textarea input field where one modifies the page's content, the annotated word disappeared. Saving the page did remove the annotated word from the page's content.
This happened with Tiki versions 15, 16 and 17, using Google Chrome versions 60 and 62 with extension versions 1.48.0.0 and 1.50.0.0, on 2 Windows machines. This reproduced whether the page's content was French or English. I however only reproduced this on local Tiki installations, except for a demonstration instance. I created a page called "HomePage2" in that instance using the default contents of Tiki's homepage.
To reproduce:
The HTTP credentials to enter the demonstration instance are "show"/"show". The password for user admin is "12345".
I did not investigate why the word is removed.