hypothesis / client

The Hypothesis web-based annotation client.
Other
630 stars 196 forks source link

Chrome extension doesn't open H overlay on Reddit.com #6463

Open chrisaldrich opened 2 months ago

chrisaldrich commented 2 months ago

A few months back Reddit updated their web UI in a redesign and as a result, trying to activate the H overlay with the bookmarklet on Chrome (Version 126.0.6478.183 (Official Build) (64-bit)) no longer works.

When I attempt to activate it on most reddit pages, the web page moves over about 75 pixels as if it's resizing and going to open the H overlay, but the overlay fails and doesn't display at all. I'm using version 1.1497.0.0 (Official Build) of the Chrome H extension.

Going to one's Reddit Settings>>Preferences and toggling "Default to old Reddit" allows one to use H on it as expected. Because the old version of Reddit works and the new doesn't, I'm presuming there's some sort of conflicting .js at play in their new UI?

I don't see a similar issue with Reddit (new or old versions) using Firefox with the Unofficial Hypothesis extension by Diego de la Hera with version 1.470.0.2self from June 2022.

robertknight commented 2 months ago

Related internal issue: https://github.com/hypothesis/support/issues/58. I'll reproduce my notes from there:

There is a CSS rule that tries to hide custom elements that are not loaded. This is unfortunately affecting our UI because it uses but doesn't register them.

*:not(:defined) {
display: none;
}

A workaround for technical users is to open developer tools, select one of the <hypothesis- elements in the Elements tab and disable this CSS rule:

Disable CSS rule