hypothesis / client

The Hypothesis web-based annotation client.
Other
642 stars 197 forks source link

Make users not to be considered members of __world__ group #6671

Closed acelaya closed 3 days ago

acelaya commented 6 days ago

This PR ensures we do not display the option to leave the "Public" (AKA world) group, as that wouldn't work anyway.

image

This has been discussed in slack https://hypothes-is.slack.com/archives/C1M8NH76X/p1731690164285009

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.43%. Comparing base (e80f694) to head (d455bf1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6671 +/- ## ======================================= Coverage 99.43% 99.43% ======================================= Files 271 271 Lines 10210 10211 +1 Branches 2431 2431 ======================================= + Hits 10152 10153 +1 Misses 58 58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

acelaya commented 3 days ago

I opened a discussion in slack to decide on the best approach to solve this https://hypothes-is.slack.com/archives/C2C2U40LW/p1732181595497659

I'm closing this for now and will reopen if a decision is made.

acelaya commented 2 days ago

Superseded by https://github.com/hypothesis/client/pull/6684