hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Establish icon-size patterns #107

Closed lyzadanger closed 2 years ago

lyzadanger commented 3 years ago

Right now, the client uses a bunch of local mixins when rendering icons to size them. It uses pixel dimensions. I'm not even sure at present how LMS handles its icon sizing.

The direction things are going now: icons would be sized as 1em, and would rely on contextual font-size for their actual dimensions. This needs some deeper thought.

Part of this work might include cataloguing the various icon dimensions in use...

lyzadanger commented 2 years ago

This should be part of #451