search

hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Do not call onConfirmRow when Enter is pressed in DataTable row children #1574

Closed acelaya closed 2 months ago

acelaya commented 2 months ago

This PR fixes a bug where elements that can be interacted with Enter key would stop the event propagation when rendered inside a DataTable row, via renderItem.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7c15e79) to head (4d9d82b).

:exclamation: Current head 4d9d82b differs from pull request most recent head 6b4785e

Please upload reports for the commit 6b4785e to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1574 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 62 62 Lines 1041 1041 Branches 397 397 ========================================= Hits 1041 1041 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.