Closed acelaya closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
ea267fe
) to head (0d300bc
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR changes
useOrderedRows
so that it can makenull
/undefined
values be put always at the bottom of the list, and makes this the default behavior.This is done by adding a new
nullsLast
option to theorder
object, which istrue
by default.Callers will need to explicitly switch from
nullsLast: true
tonullsLast: false
if they want this to change as the order direction changes:Previously we were comparing nulls normally with other non-null values, which produced unintuitive results, because in JS both
'some string' > null
andnull > 'some string'
arefalse
.