Revert "Add fill attribute to pointer-up and pointer-down icons"

hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications

https://patterns.hypothes.is

5 stars 2 forks source link

Revert "Add fill attribute to pointer-up and pointer-down icons" #1594

Closed robertknight closed 2 months ago

robertknight commented 2 months ago

Reverts hypothesis/frontend-shared#1586.

This broke rendering of the adder toolbar in the client. It turns out the fill attribute was intentionally omitted for this particular icon, with the idea being that the caller can set it on a parent DOM element and have it inherited.

Before:

After:

Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1719230027843259