search

hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Convert `useElementShouldClose` hook to TS #1600

Closed robertknight closed 1 month ago

robertknight commented 1 month ago

This hook is deprecated, but we still have 3 consumers of it in the client. Convert it to TS to make it easier to maintain in the interim. This was also the last remaining non-TS source file in this package, excluding the tests and build scripts.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (34d6062) to head (1e90757).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1600 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 62 62 Lines 1046 1047 +1 Branches 402 402 ========================================= + Hits 1046 1047 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.