hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Refactor Select documentation to no longer mention SelectNext #1620

Closed acelaya closed 1 month ago

acelaya commented 1 month ago

This PR follows-up on https://github.com/hypothesis/frontend-shared/pull/1619

This PR replaces the /input-select-next documentation page with /input-select, which has very similar content and examples, but always using Select and MultiSelect and no longer mentioning SelectNext.

Additionally, it deprecates SelectNext, and recommends using one of the other two components as drop-in replacements.

Technically speaking, two breaking changes are introduced here:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.90%. Comparing base (73dfdf2) to head (acf7bea).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1620 +/- ## =========================================== - Coverage 100.00% 99.90% -0.10% =========================================== Files 62 62 Lines 1071 1071 Branches 410 410 =========================================== - Hits 1071 1070 -1 - Misses 0 1 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acelaya commented 1 month ago

Codecov is reporting a drop in code coverage, but I think it's a false positive. Locally, it reports a coverage of 100%, and if you go to codecov's report, there's no line highlighted as uncovered.