hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Do not allow text to be selected in Select options #1657

Closed acelaya closed 2 months ago

acelaya commented 2 months ago

Avoid text to be selectable in Select.Option components.

This is specially important as we plan to support selecting multiple options via Shift + click, which selects all text in between by default.

Before:

Grabación de pantalla desde 2024-08-14 10-17-41.webm

After:

Grabación de pantalla desde 2024-08-14 10-18-09.webm

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7bb2a96) to head (781bbcd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1657 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 61 61 Lines 1040 1040 Branches 402 402 ========================================= Hits 1040 1040 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.