search

hypothesis / frontend-shared

UI components and styles for Hypothesis front-end applications
https://patterns.hypothes.is
5 stars 2 forks source link

Adjust select options gap #1674

Closed acelaya closed 2 months ago

acelaya commented 2 months ago

Part of https://github.com/hypothesis/frontend-shared/issues/1658

Increase the gap between Select/MultiSelect options icons and their content, to match the horizontal padding and make it look less heaped when the content grows to fill all available space.

Before:

image

After:

image

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (436937e) to head (88c6a33).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1674 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 61 61 Lines 1067 1067 Branches 415 415 ========================================= Hits 1067 1067 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acelaya commented 2 months ago

I have tested the component in downstream projects and everything works well, so I'm going to go ahead and merge this, as it's a very small visual change.