search

hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.96k stars 427 forks source link

Dtm exception in an image-only page #1165

Closed gergely-ujvari closed 10 years ago

gergely-ujvari commented 10 years ago

I.e. take a look at this page: http://www.frontiersin.org/files/Articles/70601/fnins-08-00058-r2/image_m/fnins-08-00058-g001.jpg

Use the bookmarklet from here: https://image13b.dokku.hypothes.is/

Result:

Uncaught TypeError: Cannot set property 'irrelevant' of undefined dom_text_mapper.js?67d8ca93:816
window.DomTextMapper.DomTextMapper._markNodeAsIrrelevant dom_text_mapper.js?67d8ca93:816
window.DomTextMapper.DomTextMapper._markNodeAsIrrelevant dom_text_mapper.js?67d8ca93:821
window.DomTextMapper.DomTextMapper.collectPositions dom_text_mapper.js?67d8ca93:881
window.DomTextMapper.DomTextMapper._startScan dom_text_mapper.js?67d8ca93:147
window.DomTextMapper.DomTextMapper.ready dom_text_mapper.js?67d8ca93:479
mapper.prepare domtextmapper.coffee:33
Guest guest.js?d19ee3a7:169
Host host.js?c28bac84:32
(anonymous function) VM64:6
yepnope.complete embed.js:36
s embed.js:4
(anonymous function) embed.js:4
a embed.js:4
a
csillag commented 10 years ago

Yeah, I am aware that they are bugs in current observer core. (That's why it's still not merged.) This might or might not be something new. I'll investigate later, when the known bugs are fixed.

csillag commented 10 years ago

This code is all gone now, so I am closing this.