search

hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.95k stars 427 forks source link

Respond to browser URL changes for single-page apps #2233

Closed afomi closed 8 years ago

afomi commented 9 years ago

As a User, I'd like to be able to annotate unique URL's in my "single-page" Ember app.

tilgovi commented 9 years ago

@afomi is the change a hash change or a history API change?

felipecocco commented 9 years ago

I have experienced issues in an Angular App as well. When I tried out Hypothesis in other pages, as I navigated through different pages it seemed that in between page-loads the hypothesis icon will flicker, presumably re-initializing with the new page's content. In the Angular App I tried, as the routes change this does not seem to happen. However, if I just click the icon twice -- "refreshing" hypothesis -- it seems to behave correctly. The app is NOT running in html5mode, and the browser navigation (back and forward buttons) transitions correctly between the two states.

judell commented 9 years ago

Tagged: compatibility

afomi commented 9 years ago

HI @tilgovi, I'm using Ember's history implementation. I'd imagine the hash change would be similar, but perhaps even more tricky, for annotation.

tilgovi commented 9 years ago

If anyone here would like to try some untested code out on the latest release, see if something like this can help you:

https://gist.github.com/tilgovi/aba591cf857efbb847c0

nickstenning commented 8 years ago

Hi there! I'm going to close this as part of a clean-up of all issues currently open on this repo that represent ideas or features rather than reports of bugs or technical chores.

I want to be clear that this isn't intended to say anything at all about the content of this issue—it certainly doesn't mean we're no longer planning to do the work discussed here—just that we don't want to use GitHub issues to track feature requests or ideas, because the threads can get long and somewhat unwieldy.

If you're interested in what we are working on at the moment, you can check out our Trello board and, for a longer-term view, our roadmap.

And, if you're interested in following up on this issue, please do continue the discussion on our developer community mailing list. You might also want to check out our contributing guide.