search

hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.91k stars 425 forks source link

Don't return replies to hidden annotations in the bulk API #8773

Closed marcospri closed 6 days ago

marcospri commented 1 week ago

Potential fix for: https://github.com/hypothesis/support/issues/66

Join on the main annotation table to find the reference to the parent, if any and check that it's visible.

robertknight commented 6 days ago

Perhaps we should fix the client to be able to show shared replies to only-me annotations (or more generally: to be able to show replies when the parent annotation(s) can't be shown).

The client can already show replies where the parent annotation is missing, if it receives them.

marcospri commented 6 days ago

Closing this in favour of a more general solution, ie one that's not scoped only to email digest.

See: https://hypothes-is.slack.com/archives/C1MA4E9B9/p1719566013178539