search

hypothesis / h

Annotate with anyone, anywhere.
https://hypothes.is/
BSD 2-Clause "Simplified" License
2.96k stars 427 forks source link

Allow groups with no scopes in admin pages #9011

Closed seanh closed 1 month ago

seanh commented 1 month ago

Problem

Previously the only way to create open or restricted groups was via the https://hypothes.is/admin/groups/new admin page and that page forced you to enter at least one scope for the group.

It's now possible to use the https://hypothes.is/groups/new page to create open and restricted groups with no scopes.

But the https://hypothes.is/admin/groups/<PUBID> page for editing an existing open or restricted group forces the group to have at least one scope.

This means that if you create an unscoped group via https://hypothes.is/groups/new and then try to edit the group via https://hypothes.is/admin/groups/<PUBID> it'll force you to enter at least one scope for the group before you can save any changes (even to other fields, e.g. the group's name).

Solution

Remove the admin pages validation requirement that groups must have at least one scope. Now you can edit unscoped groups without having to add a scope to them.

As a side-effect https://hypothes.is/admin/groups/new can now be used to create unscoped groups as well.

Testing

Go to either https://hypothes.is/admin/groups/new or https://hypothes.is/groups/new, create an open or restricted group, then go to https://hypothes.is/admin/groups/<PUBID> and edit the group without adding any scopes to it.