search

hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Add more auto-embed options #5603

Closed jeremydean closed 7 months ago

jeremydean commented 1 year ago

We currently allow for users to paste a YouTube URL into an annotation and embed the video.

We should do this for other embeddable links like Vimeo, SoundCloud and others.

robertknight commented 7 months ago

We already support Vimeo. The current complete set of recognized URL formats can be found at https://github.com/hypothesis/client/blob/6ebeef981b23a2df70fe5168b5938966a7811656/src/sidebar/media-embedder.ts#L184.

This currently includes:

robertknight commented 7 months ago

I'm going to close this for the moment and we can open more specific issues for new providers (eg. SoundCloud) in the hypothesis/client repo.