hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Validate LMS URL's on the /welcome page #592

Open seanh opened 5 years ago

seanh commented 5 years ago

The /welcome form has basically no validation of the LMS URL at all, even though this is the base URL that we used to construct Canvas API URLs in order to use the Canvas API.

seanh commented 5 years ago

Actually, if possible (if there's a suitable Canvas API endpoint) I think some JavaScript on the /welcome page should use the given LMS URL, developer key, and developer secret to make a test request to the Canvas API and only allow the form to be submitted if the test request succeeds.