search

hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Return user ID for students and an empty display_name when that's not available #6341

Closed marcospri closed 3 months ago

marcospri commented 3 months ago

We started recording student names in May 9th. Before that we only have the name if the student made an annotation as the name has always been stored in H.

Refactor the response shape to include the ID and use a now common "AnnotationMetrics" for data fetched from H in both assignments and courses responses.

marcospri commented 3 months ago

@acelaya I marked this as ready for review but it's ready for discussion instead.

If we get to a version of this we like we then need to make the FE changes.

acelaya commented 3 months ago

@acelaya I marked this as ready for review but it's ready for discussion instead. If we get to a version of this we like we then need to make the FE changes.

I think it looks good. I can do the FE changes in a branch based on this one, and merge it here first.

~Ok, I pushed to this branch by mistake 😅~ Never mid, I have rolled it back