Use h_userid instead of User to check membership to assignments

hypothesis / lms

LTI app for integrating with learning management systems

BSD 2-Clause "Simplified" License

45 stars 14 forks source link

Closed marcospri closed 1 month ago

marcospri commented 1 month ago

This allow rows in User with the same h_userid (ie the same user in different installs) to be equivalent for memberships checks.

Not reproducing the bug in local but here is how to check the fix in prod after merging:

Login in canvas as eng+canvasteacher@hypothes.is
Launch the dashboard from any (prod) assignment
Open https://lms.hypothes.is/dashboard/organizations/us.lms.org.x9L8IC7tRRa2-rYITOx_yQ/courses/10057035
You should get just one assignment that you should be able to click thru.

sentry-io[bot] commented 1 month ago

This pull request was deployed and Sentry observed the following issues:

‼️ ArgumentError: SQL expression element or literal value expected, got <lms.models.user.User object at 0x7ff767f6d... api.dashboard.assignment View Issue
‼️ ArgumentError: SQL expression element or literal value expected, got <lms.models.user.User object at 0x7fcdade1f... api.dashboard.assignment.stats View Issue

_{Did you find this useful? React with a 👍 or 👎}