hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
45 stars 14 forks source link

Allow filtering on the students metrics endpoint #6419

Closed marcospri closed 5 days ago

marcospri commented 6 days ago

For:

Testing

marcospri commented 6 days ago

@acelaya Keeping this as draft.

If we went for something like this we'd need the FE to start sending assigment_id as a query parameter instead of as part of the URL template. We can sync about how to merge/deploy the changes together.

acelaya commented 6 days ago

@acelaya Keeping this as draft.

If we went for something like this we'd need the FE to start sending assigment_id as a query parameter instead of as part of the URL template. We can sync about how to merge/deploy the changes together.

I'll create a PR based on this one, updating the FE

acelaya commented 6 days ago

I have tested the "new" endpoint and it throws a 404. Could we be missing some of those empty __init__.py files somewhere?

image

marcospri commented 6 days ago

http://localhost:8001/api/dashboard/students/metrics

This "works", it's not a 404, :thinking:, taking a look

@acelaya It was a classic assigment vs assignment. I going to write a git hook to catch these. Should work now.

acelaya commented 5 days ago

I have just created a FE PR based on this one https://github.com/hypothesis/lms/pull/6424