hypothesis / lms

LTI app for integrating with learning management systems
BSD 2-Clause "Simplified" License
46 stars 14 forks source link

Don't show empty entries in assignment filter #6456

Closed robertknight closed 1 month ago

robertknight commented 1 month ago

It can happen (@marcospri can you confirm how?) that we are missing a title for an assignment. This currently results in a blank item in the assignments filter drop-down. See the half-height item at the bottom of the list:

Blank assignments

The simplest solution is to omit these entries. An alternative solution we can implement if it becomes sufficiently important would be to display "Untitled assignment" (or similar), with some additional information to disambiguate different entries if we have multiple.

marcospri commented 1 month ago

Done, the API doesn't return now empty titled assignments.

We have https://github.com/hypothesis/lms/issues/6485 to investigate why we have those assignments in the first place.